Feature/simple structs #53
Conversation
was not used in the attestation record
| import { ResolverUID } from "../src/DataTypes.sol"; | ||
| import { console2 } from "forge-std/console2.sol"; | ||
| import "./Create2Factory.sol"; |
There was a problem hiding this comment.
I dont think this is needed right? We could just deploy using new Registry{salt: salt}()
There was a problem hiding this comment.
is that actually using 0age's factory tho? so we can use existing rust + openCL tooling to compute salts for vanity addresses?
There was a problem hiding this comment.
True, yeah this is using Nicks factory afaik so good point
| function run() public { | ||
| bytes32 salt = bytes32(uint256(2)); | ||
| bytes32 salt = 0x05a40beaf368eb6b2bc5665901a885c044c19346fc828ba80a35fe4cc30d0000; |
There was a problem hiding this comment.
Yep. just a few zeros to test that its working with the tooling we will want to use
| } | ||
| return size > 0; | ||
| function _isContract(address addr) view returns (bool) { | ||
| return addr.code.length > 0; |
There was a problem hiding this comment.
actually moved it from assembly to solidity for better readability
There was a problem hiding this comment.
Makes sense, imo bc this is super simple assembly would be fine but up to you
Co-authored-by: Konrad <[email protected]>
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
fic: more coverage
zeroknots
force-pushed
the
feature/simple-structs
branch
from
9d97822
to
406e8f4
Compare
Simplifying registry